Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to @rollup/plugin-commonjs@17.0.0 breaks svelte application #757

Closed
rsheasby opened this issue Jan 3, 2021 · 1 comment
Closed

Comments

@rsheasby
Copy link

rsheasby commented Jan 3, 2021

There seems to be an issue with the new es module reconstruction feature in 17.0.0 #537.

Everything was working without issue initially, but when I tried to upgrade my npm dependencies including this plugin to 17.0.0, I started getting the following error in my browser:

Uncaught ReferenceError: exports is not defined

When looking at my bundle, the Object.defineProperty(exports, "__esModule", statements are no longer being compiled away for some reason.

I'm unsure if this is a bug, or just a configuration problem relating to the new feature being enabled by default? If it is just a configuration change that needs to be made with the update, it's probably worth documenting this somewhere.

@rsheasby rsheasby changed the title Updating to @rollup/plugin-commonjs17.0.0 breaks svelte application Updating to @rollup/plugin-commonjs@17.0.0 breaks svelte application Jan 3, 2021
@shellscape
Copy link
Collaborator

If you are sure this is a bug or documentation issue, please take the time to refile this issue using the issue template.

Hey there, thanks for opening an issue - Unfortunately you missed (or may have disregarded) the message about issue templates being required. Because our issue template was removed, we assume that this is a support request, and that's not something we offer here. Also, if you refile, please don't ignore Issue sections. They're in the template because they're useful to the maintainers of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants