Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import statements in examples in README.md #646

Merged
merged 2 commits into from Nov 28, 2020
Merged

Fix import statements in examples in README.md #646

merged 2 commits into from Nov 28, 2020

Conversation

ryami333
Copy link
Contributor

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

Two of the import statements in examples in the README use the default export, which is incorrect (as demonstrated by the main example at the top of this file).

ryami333 and others added 2 commits November 13, 2020 15:23
Two of the import statements in examples in the README use the default export, which is incorrect (as demonstrated by the main example at the top of this file).
@shellscape shellscape merged commit ba1fcf9 into rollup:master Nov 28, 2020
@shellscape
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants