chore(repo): migrate @TrySound/rollup-plugin-eslint #575
Conversation
Adds documentation on how to use a config file at project root, mentioned in TrySound/rollup-plugin-eslint#20.
Document config file usage
|
No, not really... but I was at least planning on updating some deprecated usage of CLIEngine. |
|
If we transferred over https://github.com/robinloeffel/rollup-plugin-eslint, which already makes use of the new API, I'd totally be on board with taking the maintainer role. |
|
I've put some effort in keeping the commit history and the original author's credits. Would it work for you to make the new api changes again, after the PR is merged? |
|
I'll also volunteer to migrate the use of the new APIs and changes in that fork. @robinloeffel we'd love to have you aboard as a maintainer and I'm happy to help wherever I can to make you feel welcome. For what it's worth, it's great that the commits were able to be preserved. We'll be squashing the branch into a single commit when we merge to master to align with our repo setup here, but those commits will be part of the squashed commit message. |
shellscape
requested review from
shellscape,
Andarist,
danielgindi,
LarsDenBakker,
pnevares and
TrySound
shellscape
changed the title
packages/eslint/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "eslint": "^6.0.0", | ||
| "rollup-pluginutils": "^2.7.1" |
packages/eslint/package.json
Outdated
| "!**/recipes/**", | ||
| "!**/types.ts" | ||
| ], | ||
| "contributors": [ |
There was a problem hiding this comment.
It's probably should not be a part of ava config
|
@shellscape @atti187 Alright then, I'm in! |
|
🙏🏻 |
|
So, how do we proceed here, then? |
|
@robinloeffel I need to get off my behind and approve, merge, and publish this. It's just been a crazy month for me, new baby has thrown me for a loop. It'll happen soon, along with the graphql plugin that's waiting for the same. |
|
@shellscape Damn dude, that's big—congratulations! Take all the time you need to take care of your baby! Also don't hesitate to give me a heads-up if I can give you a hand with something on here. :) |
Congratulations man! I hope everything and everyone is well! Health for the mother and peace from the little one :) |
shellscape
changed the title
packages/eslint/LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2019 RollupJS Plugin Contributors (https://github.com/rollup/plugins/graphs/contributors) | |||
There was a problem hiding this comment.
| Copyright (c) 2019 RollupJS Plugin Contributors (https://github.com/rollup/plugins/graphs/contributors) | |
| Copyright (c) 2020 RollupJS Plugin Contributors (https://github.com/rollup/plugins/graphs/contributors) |
There was a problem hiding this comment.
I'd avoid mentioning 2020, let's skip straight to 2021
|
@robinloeffel its merged! @TrySound you're clear to archive the repo and deprecate the rollup-plugin-eslint npm package |
|
Great! Thanks. I'll do this when I come back from vacation. |
Rollup Plugin Name: eslint
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
TrySound/rollup-plugin-eslint#38
Description
TrySound/rollup-plugin-eslint#38 (comment)