-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript noEmitOnError in watch mode #272
Comments
Agreed, the program should also obey |
@NotWoods I'm doing some housekeeping on old issues. Should we take this one up? |
I'll take this on. |
I think there are multiple things we can do here:
|
|
I tested
I think the behavior you suggested sounds reasonable enough though and will avoid the vast majority of users from hitting this issue |
I see that we also override the defaults for
|
PR submitted for this in #544 |
Aye I think we'll close this one. |
Feature Use Case
Using rollup in watch mode, the TS compiler shouldn't break the watcher with default options.
Now you need to add
typescript({ noEmitOnError: false })
inrollup.config.js
for the watcher to work properly.Feature Proposal
https://github.com/rollup/plugins/tree/master/packages/typescript#noemitonerror the
noEmitOnError
default should befalse
, so that rollup usage would be more intuitive.Ref - #258
The text was updated successfully, but these errors were encountered: