Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second build fails when incremental set to true #249

Closed
moeriki opened this issue Mar 9, 2020 · 9 comments
Closed

Second build fails when incremental set to true #249

moeriki opened this issue Mar 9, 2020 · 9 comments

Comments

@moeriki
Copy link

moeriki commented Mar 9, 2020

  • Rollup Plugin Name: typescript
  • Rollup Plugin Version: 4.0.0
  • Rollup Version: 2.0.2
  • Operating System (or Browser): macOS 10.15.3 (19D76)
  • Node Version: 12.16.0

How Do We Reproduce?

git clone git@github.com:Moeriki/bug-rollup-ts-incremental.git
cd bug-rollup-ts-incremental/
npm install
npm run build
npm run build

Expected Behavior

Build succeeds two times.

Actual Behavior

Build fails the second time.

Work-around

npm run build
npm run clean
npm run build

Or set compilerOptions.incremental to false.

@shellscape
Copy link
Collaborator

@moeriki thanks for the issue. Please verify that this also happens when using NPM. NPM is our baseline in the project for issues and repo-based reproductions.

@moeriki
Copy link
Author

moeriki commented Mar 9, 2020

Tested and verified the same issue with npm. Updated issue to reflect.

The issue though may be related to my compiler options. I'm still testing some things.

@VitorLuizC
Copy link
Contributor

VitorLuizC commented Apr 24, 2020

Same happens here and we're using PNPM.

Maybe this is the cause of #287

@shellscape
Copy link
Collaborator

Please use the "edit" function on replies to add info and cut down on noise.

@shellscape
Copy link
Collaborator

Hey folks. This issue hasn't received any traction for more than 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

@VitorLuizC
Copy link
Contributor

This was fixed?

@shellscape
Copy link
Collaborator

@VitorLuizC please re-read my previous comment.

@VitorLuizC
Copy link
Contributor

VitorLuizC commented Jul 9, 2020

@shellscape I don't understand the concept of housekeeping. You're closing an issue that is not fixed to reduce number of open issues? I can't see the advantages in doing that. Can you explain me that?

@shellscape
Copy link
Collaborator

It's quite simple really; we have finite resources and must focus on issues that have activity and active triage. Housekeeping is very common in large projects (most even have bots that handle it for the project). We haven't received any help from the community to resolve this, which is unfortunate but OK, so we're closing this until such time that someone would like to pick up the effort.

If you're interested in contributing a fix for this issue, please do open a PR and we'll get some folks to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants