Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rollup/plugin-typescript noEmitOnError should default to true #1444

Closed
gempain opened this issue Feb 23, 2023 · 2 comments
Closed

@rollup/plugin-typescript noEmitOnError should default to true #1444

gempain opened this issue Feb 23, 2023 · 2 comments

Comments

@gempain
Copy link

gempain commented Feb 23, 2023

  • Rollup Plugin Name: @rollup/plugin-typescript
  • Rollup Plugin Version: 11.0.0 and before

Expected Behavior / Situation

noEmitOnError should be true by default. It makes no sense to emit code when the Typescript build fails. It can lead to production code not working as expected.

Actual Behavior / Situation

By default the value is false.

Modification Proposal

Change the value from false to true.

@pimartin
Copy link

It looks like it was introduced for the watch mode.

Maybe a slightly more complex default could be used: false when in watch mode, true otherwise ?

@stale stale bot added the x⁷ ⋅ stale label Apr 26, 2023
@stale
Copy link

stale bot commented May 2, 2023

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

@stale stale bot closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants