docs(node-resolve): improve doc related to mainFields #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More clear doc related to mainFields priority and distinct options for browser, module, jsnext and main. Rework markup to distinguish values of mainFields and corresponding values in package.json.
Closed
shellscape
changed the title
|
Docs created according to this function. |
|
Note to reviewers: We can safely ignore the failing Windows tests for now. #137 contains a fix for that. |
shellscape
reviewed
Jan 3, 2020
Simplify valid values Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
shellscape
reviewed
Jan 3, 2020
shellscape
reviewed
Jan 3, 2020
shellscape
reviewed
Jan 3, 2020
shellscape
reviewed
Jan 3, 2020
Kocal
approved these changes
Jan 3, 2020
shellscape
reviewed
Jan 3, 2020
shellscape
requested changes
Jan 3, 2020
Remove Type/Default info on deprecated properties: jsnext, module and main.
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
shellscape
approved these changes
Jan 4, 2020
|
|
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* node-resolve: improve doc related to mainFields Fixes rollup#66 More clear doc related to mainFields priority and distinct options for browser, module, jsnext and main. Rework markup to distinguish values of mainFields and corresponding values in package.json. * Update packages/node-resolve/README.md Simplify valid values Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com> * node-resolve: remove type info on deprec options Remove Type/Default info on deprecated properties: jsnext, module and main. * Update packages/node-resolve/README.md Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com> * Update packages/node-resolve/README.md Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com> Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
rollup-plugin-node-resolveThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
More clear doc related to mainFields priority and distinct options for browser, module, jsnext and main. Rework markup to distinguish values of mainFields and corresponding values in package.json.