Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comprehensive tests for error scenarios in TestVoteExtension. #1663

Open
tzdybal opened this issue May 7, 2024 · 0 comments · May be fixed by #1690
Open

Add comprehensive tests for error scenarios in TestVoteExtension. #1663

tzdybal opened this issue May 7, 2024 · 0 comments · May be fixed by #1690
Labels
good first issue Good for newcomers needs-triage T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:testing Related to testing

Comments

@tzdybal
Copy link
Member

tzdybal commented May 7, 2024 •
edited

Add comprehensive tests for error scenarios in TestVoteExtension.

The current implementation of TestVoteExtension tests the happy path where everything functions as expected. It would be beneficial to include tests for error scenarios, such as what happens when the ExtendVote or PrepareProposal methods fail. Would you like me to help by adding these tests or should I open a GitHub issue to track this task?

Originally posted by @coderabbitai[bot] in #1641 (comment)
@tzdybal tzdybal added good first issue Good for newcomers T:testing Related to testing T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels May 7, 2024
@tzdybal tzdybal mentioned this issue May 7, 2024
Merged
@PrathyushaLakkireddy PrathyushaLakkireddy linked a pull request Jun 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needs-triage T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:testing Related to testing
Projects
Rollkit
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add comprehensive tests for error scenarios in TestVoteExtension PrathyushaLakkireddy/rollkit
1 participant
@tzdybal