-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gracefull shutdown of node instead of panicking #1591
Comments
Hi @tzdybal , can I work on this issue? |
I am thinking of lifting the error to top level and handling it there
and the caller would be something like this
if that looks a bit weird, I can try defining a custom error to differentiate between to them. Or please do let me know if there is any other way, I will look into it @tzdybal . |
Hey @Teja2045. Thanks for interest in the issue. I think that we need a little bigger refactoring in codebase to cleanup the relations and life-cycle of various components. Introducing second return error is non-idiomatic for Go. It will be super confusing. |
thanks for reply @tzdybal. that makes sense. indeed, aside from error handling, a lot of cleanups need to be added to free the memory. If there is a bit more context on this issue, I would love to contribute, Thanks! |
Originally posted by @MSevey in #1568 (comment)
The text was updated successfully, but these errors were encountered: