Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech debt][da]: move sentinel errors to go-da #1578

Open
tuxcanfly opened this issue Feb 28, 2024 · 0 comments
Open

[tech debt][da]: move sentinel errors to go-da #1578

tuxcanfly opened this issue Feb 28, 2024 · 0 comments
Labels
T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@tuxcanfly
Copy link
Contributor

Implementation ideas

After #1535 certain celestia errors are special cased to handle fee, mempool, block size errors.

This breaks the clean abstraction promised by go-da. Ideally these errors should be moved go-da.
@tuxcanfly tuxcanfly mentioned this issue Feb 28, 2024
Merged
5 tasks
@Manav-Aggarwal Manav-Aggarwal added T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. and removed needs-triage labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
Rollkit
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuxcanfly @Manav-Aggarwal