Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Untrusted Header height validation #1496

Open
oxnr opened this issue Jan 17, 2024 · 1 comment
Open

Incorrect Untrusted Header height validation #1496

oxnr opened this issue Jan 17, 2024 · 1 comment

Comments

@oxnr
Copy link

oxnr commented Jan 17, 2024

Finding 036 - Incorrect Untrusted Header height validation

ID 036
Finding Incorrect Untrusted Header height validation
Severity 0 - Informational
Description Untrusted header height is expected to be >= the trusted header but in reality it should just be == to trusted header +1.
Recommendation Fix the validation step to do an equality check.
Code References
if sh.Height()+1 < untrstH.Height() {


@Manav-Aggarwal
Copy link
Member

Making the change from >= the trusted header to == trusted header +1 causes issues with https://github.com/celestiaorg/go-header. Needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants