feat: enabled workflow cancellation for "Waiting" workflows #11
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xShteff this is great, thanks for bringing it to my attention! I wasn't aware of this change to github actions, but it's awesome so thanks for taking the time to open the PR. |
rokroskar
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rokroskar, hope you don't mind I get my hands in this!
Sorry for the commit message, I didn't really plan on opening a PR initially - but I believe if you choose "Squash and merge" it should get rid of my commit message and allow you to use the title of the PR as one.
GitHub has recently enabled Environment protections, which means that workflows can now be marked as "Waiting" - if you have it enabled. It'll look something like this:
I tried it in my fork and a private repo and it seemed to work :p