-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pre-commit hook out of this repository #188
Comments
ideally it should not point to latest docker image, rather be updated and fixed on each release |
Just to be clear, I'm aware of pyspelling hook in the other repo. I'm specifically calling for docker contained pyspelling hook. |
Hmm I have some issues using this as a pre-commit hook. Locally I have no problems, however as running pre-commit is part of ci/cd it also gets run at testing pipeline and fails at :
Is is possible that it's permissions level at the mounted directory to src/? |
Hi @Lasica Sounds like it. |
Yeah I've changed permissions to this file to be writable by everyone and it fixed the issue, although I can't do the same for environment in cicd. It would be better if this file was created and accessed in some tmp directory in docker, maybe? |
Hello, I've had a need to add spellchecking to my repo docs. For this purpose I've created my hook definition based on this repository. I think that's probably a small addition that would be welcome and more fitting in this repository directly.
All it takes is properly defined
pre-commit-hooks.yml
file. Here is sample of what my looks like:with readme description of how to configure it:
Define in
.pre-commit-config.yaml
:What do you think? Do you want PR for this?
The text was updated successfully, but these errors were encountered: