Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with rack 2.0.8 #116

Closed
fabn opened this issue Dec 19, 2019 · 6 comments
Closed

Not working with rack 2.0.8 #116

fabn opened this issue Dec 19, 2019 · 6 comments

Comments

@fabn
Copy link

fabn commented Dec 19, 2019

I've updated to rack 2.0.8 because of CVE-2019-16782 but my application has problems and raise an error with that version of rack when accessing sidekiq interface.

Here's the involved rack commit
rack/rack@7fecaee

And I get an error coming from this line that calls this line

@majksner
Copy link

New Rack 2.1.1 was released that fixes this issue with rack/rack#1462

@Jesterovskiy
Copy link
Collaborator

Nice to hear that, I'll close this issue

@majksner
Copy link

I'm still getting error, this time different one when accessing Sidekiq UI.

Screen Shot 2020-01-13 at 09 18 50

@Jesterovskiy
Copy link
Collaborator

@majksner strange, I see this in 2.1.1 release rack/rack@8659d9f

@majksner
Copy link

@jessedoyle Yes, but that's in the master, not yet released. 2.1.1 tag doesn't have that fix.

https://github.com/rack/rack/blob/2.1.1/lib/rack/session/abstract/id.rb

@Jesterovskiy
Copy link
Collaborator

You right) you can use master branch then and wait for release with fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants