Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork-safety #140

Open
rohanpm opened this issue Apr 11, 2019 · 1 comment
Open

Improve fork-safety #140

rohanpm opened this issue Apr 11, 2019 · 1 comment

Comments

@rohanpm
Copy link
Owner

rohanpm commented Apr 11, 2019

I haven't investigated the behavior on fork, but as several futures created by this library are backed by threads and as threads aren't copied over a fork, it seems likely that an application using more-executors and fork() could end up with a bunch of futures which hang when accessed.

It would be nice if this could be improved. It can't be made to "work", but it could possibly be made to fail in a predictable way.

For example, can we make it so that after a fork, any future which depended on a disappeared thread is automatically failed?

@rohanpm
Copy link
Owner Author

rohanpm commented Apr 11, 2019

Executors themselves would also have to be marked either as dead, or have the ability to restart their dead worker threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant