testscript: exit 0 in runCoverSubcommand if -help is used #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag.ExitOnError will exit 0 for -h/-help, while the flag.PanicOnError override in runCoverSubcommand was always exiting 2, making the success/failure of running a command with -hhelp depend on whether coverage is active.
mvdan
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
SGTM. We probably inherited or wrote this code before golang/go#37533 landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag.ExitOnError will exit 0 for -h/-help, while the flag.PanicOnError
override in runCoverSubcommand was always exiting 2, making the
success/failure of running a command with -hhelp depend on whether
coverage is active.