Set Library Search Order doesn't work if there are two matches and one is from standard libraries

[jaasal]

Versions: Robot Framework 6.0, Python 3.8.10, Windows 10
Prerequisites: robotframework-sshlibrary installed

Execute the following test:

*** Settings ***
Library  SSHLibrary
Library  OperatingSystem

*** Test Cases ***
Test Library Search Order
  Set Library Search Order  OperatingSystem  SSHLibrary  
  Get File  ./foo.txt

Expected: Get File -keyword from OperatingSystem is executed
Actual: Warning about duplicate keywords is shown, Get File -keyword from SSHLibrary is executed

[pekkaklarck]

Did this work before RF 6.0?

[jaasal]

Did this work before RF 6.0?

Yes, we updated from 5.0 and there it did work.

[pekkaklarck]

Ok. I think I know what caused that. Needs to be fixed in 6.0.1.

[pekkaklarck]

This regression occurs if there are two matches and one of them are from a standard library. In such cases we in general give precedence to the other keyword, but the search order should be used first and in this case it would resolve the conflict. Although Set Library Search Order isn't totally broken, this is definitely a high priority regression.

This was most likely broken when related code was enhanced as part of #4454. It's a stupid logic bug that's easy to fix. Somewhat surprising we didn't have any tests for this scenario.