Use real Android code for ContentProviderClient.release #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_413795247
branch
from
b3d25b9
to
dccf8ef
Compare
hoisie
force-pushed
the
piper_413795247
branch
from
dccf8ef
to
3d3b1d0
Compare
This fixes two issues: 1) Because 'release' was shadowed, the underlying CloseGuard for the ContentProviderClient was never closed, leading to CloseGuard errors that could not be suppressed. 2) The behavior of 'release' was not correct for SDK > 23, where calling it multiple times does not result in an IllegalStateException. Also, update ShadowContentProviderClientTest to use a real ContentProvider, and remove the interaction test. Trying to release a ContentProviderClient for a mock ContentProvider results in an exception. PiperOrigin-RevId: 413795247
hoisie
force-pushed
the
piper_413795247
branch
from
3d3b1d0
to
5082bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use real Android code for ContentProviderClient.release
This fixes two issues:
Because 'release' was shadowed, the underlying CloseGuard for the
ContentProviderClient was never closed, leading to CloseGuard errors that could
not be suppressed.
The behavior of 'release' was not correct for SDK > 23, where calling it
multiple times does not result in an IllegalStateException.
Also, update ShadowContentProviderClientTest to use a real ContentProvider, and
remove the interaction test. Trying to release a ContentProviderClient for a
mock ContentProvider results in an exception.