Fix remaining CloseGuard warnings in Robolectric tests #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
hoisie
force-pushed
the
piper_413781118
branch
from
d0caf66
to
dae9bb1
Compare
CloseGuard warnings and stack traces accounted for ~40% of log lines during Robolectric tests. This will remove around ~3.5k CloseGuard errors and stack traces in the Robolectric test suite. PiperOrigin-RevId: 413781118
hoisie
force-pushed
the
piper_413781118
branch
from
dae9bb1
to
bceed50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix remaining CloseGuard warnings in Robolectric tests
CloseGuard warnings and stack traces accounted for ~40% of log
lines during Robolectric tests.
This will remove around ~3.5k CloseGuard errors and stack traces in the
Robolectric test suite.