Switch to Ninja for building the native runtime #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_413717789
branch
from
ac62e00
to
e2c9b5a
Compare
The version of `make` provided in the MSYS2 does not work well with CMake on Windows. This makes it impossible to do incremental nativeruntme builds on Windows. See https://stackoverflow.com/questions/2401976 for more details on the issue. Switch to using Ninja everywhere, which seems to be more reliable across platforms. PiperOrigin-RevId: 413717789
hoisie
force-pushed
the
piper_413717789
branch
from
e2c9b5a
to
91631f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Ninja for building the native runtime
The version of
makeprovided in the MSYS2 does not work well with CMake onWindows. This makes it impossible to do incremental nativeruntme builds on
Windows.
See https://stackoverflow.com/questions/2401976 for more details on the issue.
Switch to using Ninja everywhere, which seems to be more reliable across
platforms.