Add support for building Robolectric's nativeruntime with gcc/g++ #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_413475269
branch
2 times, most recently
from
088eea6
to
e6f31a7
Compare
g++ is sensitive to the order of libraries in command-line arguments. It requires -ldl to be provided after the ICU static libraries, not before. Update the order by placing -ldl and -lpthread as part of the androidsqlite project, where they are required. PiperOrigin-RevId: 413475269
hoisie
force-pushed
the
piper_413475269
branch
from
e6f31a7
to
a18d615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for building Robolectric's nativeruntime with gcc/g++
g++ is sensitive to the order of static libraries. It requires -ldl to be
provided after the ICU static libraries, not before. Update the order by
placing -ldl and -lpthread as part of the androidsqlite project, where they are
required.