Only using AttributionSource for compile sdk 31 and above

[utzcoz]

Fixes #6883.

[utzcoz]

Also testing it with example provided #6883 and Robolectric local SNAPSHOT.

[utzcoz]

Looks like it breaks ShadowAppOpsManagerTest. I will check it.

[utzcoz]

Looks like it uses real noteProxyOpNoThrow with AttributionSource input instead of changed method with Object type for AttributionSource.

[utzcoz]

What about only loading methods and related classses supported by current running SDK? For example, if we only run tests with SDK 30, we will not load methods needs SDK 31 and above. But I remember there are some methods have been mixed with other purpose, for example normal API function invoked by other methods supported by other APIs.

[hoisie]

Can you squash the last 2 commits so ShadowAppOpsManagerTest is not broken in a commit.

[hoisie]

Thanks for doing this! Only one minor thing -- squash the last 2 commits.

[hoisie]

FWIW, long-term, I think there could be better alternatives to looseSignatures . For instance, if shadows supported reflector's WithType, that method could be:

@Implementation(minSdk = Build.VERSION_CODES.S)
  protected int noteProxyOpNoThrow(
      int op,
      @WithType("android.content.AttributionSource") Object attributionSource,
      String message,
      boolean ignoredSkipProxyOperation) { ... }

The advantage of this is that you don't have to worry about casting all of the types, only the problemetic ones.

[utzcoz]

FWIW, long-term, I think there could be better alternatives to looseSignatures . For instance, if shadows supported reflector's WithType, that method could be:

@Implementation(minSdk = Build.VERSION_CODES.S)
  protected int noteProxyOpNoThrow(
      int op,
      @WithType("android.content.AttributionSource") Object attributionSource,
      String message,
      boolean ignoredSkipProxyOperation) { ... }

The advantage of this is that you don't have to worry about casting all of the types, only the problemetic ones.

I prefer this method more than current looseSignatures. It only needs to change needed input parameters, not all of one method. I will fire an issue to track it.

[utzcoz]

Thanks for doing this! Only one minor thing -- squash the last 2 commits.

Done.

[hoisie]

I'll do a 4.7.3 release with this and #6880

[hoisie]

This should now be fixed in 4.7.3 (may take a minute or two for that to appear on MavenCentral).