Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'processResources' task instead of 'jar' task for nativeruntime #6874

Merged
merged 1 commit into from Nov 21, 2021

Conversation

hoisie
Copy link
Contributor

@hoisie hoisie commented Nov 20, 2021

The 'processResources' is better designed to copy resources. This solves
an issue with the 'jar' task rewriting the nativeruntime mac artifacts,
which have to be placed in the resources folder manually for building
the uber JAR.

The 'processResources' is better designed to copy resources. This solves
an issue with the 'jar' task rewriting the nativeruntime mac artifacts,
which have to be placed in the resources folder manually for building
the uber JAR.
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also more concise than before. Could this PR can be merged today? I will rebase my work on this PR.

@hoisie hoisie merged commit 7502aa1 into robolectric:master Nov 21, 2021
@hoisie hoisie deleted the use-process-resources branch November 21, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants