Fix theme native object collection in Android S #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
hoisie
force-pushed
the
piper_411169531
branch
2 times, most recently
from
bb8c264
to
8b5890b
Compare
Previously, in Android P through R, Robolectric would clean up native themes from the registry when AssetManager.nativeThemeDestroy was called by the ThemeImpl finalizer. However, starting in Android S, AssetManager.nativeThemeDestroy does not exist any more. As a workaround, hook into the AssetManager.releaseTheme method to free the theme from the registry. Longer term we may want to have the theme destruction logic be part of AssetManager.nativeDestroy, where all themes can potentially be freed in one fell swoop. This should fix #6872. Thanks to @calvarez-ov for reporting the issue and helping debug :) PiperOrigin-RevId: 411169531
hoisie
force-pushed
the
piper_411169531
branch
from
8b5890b
to
23ff946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix theme native object collection in Android S
Previously, in Android P through R, Robolectric would clean up native themes
from the registry when AssetManager.nativeThemeDestroy was called by the
ThemeImpl finalizer. However, starting in Android S,
AssetManager.nativeThemeDestroy does not exist any more.
As a workaround, hook into the AssetManager.releaseTheme method to free the
theme from the registry. Longer term we may want to have the theme destruction
logic be part of AssetManager.nativeDestroy, where all themes can potentially
be freed in one fell swoop.
This should fix #6872. Thanks to @calvarez-ov for reporting the issue and
helping debug :)