Add ActivityController.close that transitions Activity to destroyed state #6864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_410291892
branch
2 times, most recently
from
1be6910
to
936637a
Compare
hoisie
force-pushed
the
piper_410291892
branch
2 times, most recently
from
31be693
to
1a350f7
Compare
…tate Update ActivityController to implement AutoCloseable, and add a 'close' method that is lifecycle-aware and transitions the underlying Activity to the destroyed state, freeing all resources and making the Activity eligible for gc. This is a convenient way to ensure that ActivityControllers can be freed without having to manage the underlying Activity lifecycles. It also enables ActivityController to be managed using try-with-resources. PiperOrigin-RevId: 410291892
hoisie
force-pushed
the
piper_410291892
branch
from
1a350f7
to
feaded1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ActivityController.close that transitions Activity to destroyed state
Update ActivityController to implement AutoCloseable, and add a 'close' method
that is lifecycle-aware and transitions the underlying Activity to the destroyed
state, freeing all resources and making the Activity eligible for gc.
This is a convenient way to ensure that ActivityControllers can be freed without
having to manage the underlying Activity lifecycles.
It also enables ActivityController to be managed using try-with-resources.