Add solution log for unhandled PNG file #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is printed log at terminal. |
|
Hi @ganadist , it's nice if you help to take look at it, and check it with your demo. |
hoisie
reviewed
Nov 7, 2021
|
The new print log is here:
|
|
Hope this PR can get enough testing. |
|
The testing is here #6812 (comment). |
|
Hi @hoisie , could you help to review this PR again? Thanks. |
hoisie
reviewed
Nov 16, 2021
shadows/framework/src/main/java/org/robolectric/shadows/ImageUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
…gth" Signed-off-by: utzcoz <utzcoz@outlook.com>
utzcoz
force-pushed
the
add-solution-log-for-unhandled-PNG-file
branch
from
50249f2
to
2d3729e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6812.
I don't have related images without copyright problem for this change, so I tested it with demo at #6812. It will print a log for unhandled PNG file with link #6812. The developer can get potential solution from this issue's discussion.