Support overriding Icon loading executor from Icon#loadDrawableAsync. #6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_407821420
branch
from
ac7f04d
to
9244b03
Compare
Icon#loadDrawableAsync is loading icon on AsyncTask#THREAD_POOL_EXECUTOR, that test has no way to control the execution. This patch adds a dedicated executor overriding as ShadowIcon#overrideExecutor to let test control where the async icon loading will happen. PiperOrigin-RevId: 407821420
hoisie
force-pushed
the
piper_407821420
branch
from
9244b03
to
6beade5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support overriding Icon loading executor from Icon#loadDrawableAsync.
Icon#loadDrawableAsync is loading icon on AsyncTask#THREAD_POOL_EXECUTOR, that test has no way to control the execution. This patch adds a dedicated executor overriding as ShadowIcon#setIconAsyncLoadingExecutor to let test control where the async icon loading will happen.