Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling GLSurfaceView does not stop the created gl thread #7194

Open
hoisie opened this issue Mar 26, 2022 · 4 comments · May be fixed by #8871
Open

Calling GLSurfaceView does not stop the created gl thread #7194

hoisie opened this issue Mar 26, 2022 · 4 comments · May be fixed by #8871
Labels
help wanted starter issue Small/simple issues for new contributors

Comments

@hoisie
Copy link
Contributor

hoisie commented Mar 26, 2022

When GLSurfaceView is used, the gl thread created in GLSurfaceView does not get terminated after the test finished.

ShadowGLSurfaceView probably needs a @resetter method that kills an existing threads? Another option is to terminate the thread in callOnDetachFromWindow, or to try to mimic the Android behavior of terminating the thread.
@hoisie hoisie added the starter issue Small/simple issues for new contributors label Mar 26, 2022
@Abdulrahman1890
Copy link

Inform me with more details plz

@utzcoz
Copy link
Member

utzcoz commented Apr 9, 2022

Inform me with more details plz

It's not recommended to trying multiple starter issues at once. If you have interested into one issue, please try to finish that one firstly, instead of trying multiple issues the same time. We don't have enough starter issues now, and they should be left for newbies. This behavior will affect other folks to leave interesting comment because they maybe think this issue is assigned to one folk commented before.

@Abdulrahman1890
Copy link

Oh, So sorry I wasn't know that.. I just want to contribute and solve an issue to be able to contribute in the main project with GSOC and send my proposal before the deadline

@arsalanahmad4
Copy link

@hoisie Can you please elaborate a little more on the issue?

@Devashishbasu Devashishbasu linked a pull request Feb 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted starter issue Small/simple issues for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added code to stop gl thread Devashishbasu/robolectric
4 participants
@hoisie @utzcoz @arsalanahmad4 @Abdulrahman1890