Skip to generate shadowOf for ShadowBackdropFrameRenderer #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BackdropFrameRenderer is private/hidden/internal API, and we don't need to generate shadowOf for this class. Signed-off-by: utzcoz <utzcoz@outlook.com>
|
When I tried to upgrade Robolectric 4.8 for Flutter at PR flutter/engine#33024, tests of Flutter failed when it uses |
hoisie
approved these changes
Apr 30, 2022
This was referenced May 2, 2022
|
Hi @hoisie @JuliaSullivanGoogle , will we have a 4.8.1 release with this commit at this week? cc @ganadist |
|
Yeah definitely I will start the process ASAP |
|
4.8.1 is out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BackdropFrameRendereris private/hidden/internal API, and we don't need to generateshadowOffor this class.