Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestDisallowInterceptTouchEvent doesn't propagate #7266

Closed
wesalvaro opened this issue Apr 22, 2022 · 4 comments
Closed

requestDisallowInterceptTouchEvent doesn't propagate #7266

wesalvaro opened this issue Apr 22, 2022 · 4 comments

Comments

@wesalvaro
Copy link
Contributor

Description

The ViewGroupShadow does not propagate requestDisallowInterceptTouchEvent. This leads to bugs in testing when that feature is needed.

Robolectric & Android Version

head & any
@wesalvaro
Copy link
Contributor Author

I have an internal cl/443649582 to fix this.

@utzcoz
Copy link
Member

utzcoz commented Apr 22, 2022

Hi @wesalvaro Could you contact @hoisie internally to sync it to public repo? Thanks.

@wesalvaro
Copy link
Contributor Author

Roger roger.

@copybara-service copybara-service bot mentioned this issue Apr 26, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Apr 26, 2022
@wesalvaro
Fixes #7266 touch event disallow propagation.
0533029 
Directly calls `requestDisallowInterceptTouchEvent` on the view.
This allows the flags to be properly sent up the view tree.

PiperOrigin-RevId: 443649582
copybara-service bot pushed a commit that referenced this issue Apr 26, 2022
@wesalvaro
Fixes #7266 touch event disallow propagation.
ea3e5d1 
Directly calls `requestDisallowInterceptTouchEvent` on the view.
This allows the flags to be properly sent up the view tree.

PiperOrigin-RevId: 444509476
@utzcoz
Copy link
Member

utzcoz commented Apr 26, 2022

Fixed by ea3e5d1. It will be merged into master branch at next period.

@utzcoz utzcoz closed this as completed Apr 26, 2022
hoisie pushed a commit that referenced this issue Apr 26, 2022
@wesalvaro @hoisie
Fixes #7266 touch event disallow propagation.
18b8fc2 
Directly calls `requestDisallowInterceptTouchEvent` on the view.
This allows the flags to be properly sent up the view tree.

PiperOrigin-RevId: 444509476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesalvaro @utzcoz