Fix how the OnInitListener is invoked in ShadowTextToSpeech #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_350776217
branch
from
603510b
to
165caec
Compare
hoisie
force-pushed
the
piper_350776217
branch
from
165caec
to
088e40d
Compare
Previously, in ShadowTextToSpeech, the OnInitListener callback was always called inline with the ERROR code. Instead, default to calling it asynchronously with the SUCCESS code, which is what happens in real Android. In the case that tests want to check the error condition, add a new API ShadowTextToSpeech.setOnInitStatus(int) which can be used to set the status code used in the callback. PiperOrigin-RevId: 350776217
hoisie
force-pushed
the
piper_350776217
branch
from
088e40d
to
1d93497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how the OnInitListener is invoked in ShadowTextToSpeech
Previously, in ShadowTextToSpeech, the OnInitListener callback was always
called inline with the ERROR code. Instead, default to calling it
asynchronously with the SUCCESS code, which is what happens in real Android.
In the case that tests want to check the error condition, add a new API
ShadowTextToSpeech.setOnInitStatus(int) which can be used to set the status
code used in the callback.