New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String with URL and Email ignores finder.url_must_have_scheme ? #44
Comments
As a workaround it is possible to split a string in spans:
|
Not sure if it helps but can you also check against #43? |
Mh, I've switched to a simple RegEx approach as I've observed additional issues in my test case. Urls in my data are not too complicated. So even the workaround above did not fix all issues. |
Yep, #43 fixes that problem too, I'll add that as a test case. @thomasgloe can you provide the additional problematic cases that you've found here? |
Code example:
results in:
But I would expect:
|
Indeed, I've checked with |
Good to hear! To be honest, the implementation of the I'm releasing the change soon. |
Alright, released as 0.9.0 🎉: https://github.com/robinst/linkify/blob/main/CHANGELOG.md#090---2022-07-11 |
Hi,
I tested the example from the docs and it works great:
However, when the input string is changed to
let input = "Look, no scheme: example.org/foo email@foo.com";
The url
example.org/foo
is not detected anymore. The same applies to the demo website https://robinst.github.io/linkify/ with the input string.Is this the expected outcome or a bug? Is there any additional switch to detect the url even if there is an email in a string?
Related to #8
The text was updated successfully, but these errors were encountered: