Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncDataloader improvements for Rails #4921

Open
rmosolgo opened this issue Apr 17, 2024 · 0 comments · May be fixed by #4944
Open

AsyncDataloader improvements for Rails #4921

rmosolgo opened this issue Apr 17, 2024 · 0 comments · May be fixed by #4944

Comments

@rmosolgo
Copy link
Owner

The AsyncDataloader could be improved in some ways to support Rails better:

  • With isolation_level = :fiber, if you call connected_to { ... } in the surrounding context (parent Fiber), then child Fibers don't respect that -- but they should in this case.
  • Database connections used by Fibers aren't released automatically when the Fiber terminates. AsyncDataloader should manually release its connection when its work is finished

I think these are both good defaults and it can be accomplished with a Rails-specific module included as-needed, or something similar.

@rmosolgo rmosolgo linked a pull request May 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant