Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Language::Nodes::AbstractNode#initialize #4854

Open
rmosolgo opened this issue Feb 22, 2024 · 2 comments
Open

Refactor Language::Nodes::AbstractNode#initialize #4854

rmosolgo opened this issue Feb 22, 2024 · 2 comments
Milestone
3.0

Comments

@rmosolgo
Copy link
Owner

It uses keyword arguments which requires Ruby to allocate a Hash. (This is only for .new -> #initialize.) See #4718 (comment)
@rmosolgo rmosolgo added this to the 3.0 milestone Feb 22, 2024
@rmosolgo rmosolgo mentioned this issue Apr 17, 2024
Closed
@tenderlove
Copy link
Contributor

If I can get this and this landed in Ruby 3.4, it will eliminate the hash allocation. If you like the kwargs, keep them! 😄

@rmosolgo
Copy link
Owner Author

Wow, that would be great. I'll keep an eye on those PRs, thanks!

@rmosolgo rmosolgo mentioned this issue Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@tenderlove @rmosolgo