Support returning [Type, nil] from resolve_type #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
added a commit
that referenced
this pull request
Mar 29, 2023
#4130 fixed returning `[Type, nil]` from a union's `resolve_type`, but it caused a regression for literal `false` values. `Schema#resolve_type` had a `if resolved_value` conditional would be false for `false` values causing it _always_ return a single value (the `resolve_type`). The runtime's `resolve_type` method would then _always_ return the tuple version (in non-lazy cases): `[type, value]`. However, since `Schema#resolve_type` was only returning a single value, the resolved value would be lost resulting in `[type, nil]` being passed on. The fix is to remove the `if resolved_value` conditional entirely and always return the two-value tuple ensuring the original resolved value is correctly passed along. Note: the runtime still has a branch to check if the `resolve_type` value is a tuple or not. The only case where this won't be true is for lazy resolved types.
swalkinshaw
added a commit
that referenced
this pull request
Mar 29, 2023
#4130 fixed returning `[Type, nil]` from a union's `resolve_type`, but it caused a regression for literal `false` values. `Schema#resolve_type` had a `if resolved_value` conditional would be false for `false` values causing it _always_ return a single value (the `resolve_type`). The runtime's `resolve_type` method would then _always_ return the tuple version (in non-lazy cases): `[type, value]`. However, since `Schema#resolve_type` was only returning a single value, the resolved value would be lost resulting in `[type, nil]` being passed on. The fix is to remove the `if resolved_value` conditional entirely and always return the two-value tuple ensuring the original resolved value is correctly passed along. Note: the runtime still has a branch to check if the `resolve_type` value is a tuple or not. The only case where this won't be true is for lazy resolved types.
rmosolgo
pushed a commit
that referenced
this pull request
Mar 29, 2023
#4130 fixed returning `[Type, nil]` from a union's `resolve_type`, but it caused a regression for literal `false` values. `Schema#resolve_type` had a `if resolved_value` conditional would be false for `false` values causing it _always_ return a single value (the `resolve_type`). The runtime's `resolve_type` method would then _always_ return the tuple version (in non-lazy cases): `[type, value]`. However, since `Schema#resolve_type` was only returning a single value, the resolved value would be lost resulting in `[type, nil]` being passed on. The fix is to remove the `if resolved_value` conditional entirely and always return the two-value tuple ensuring the original resolved value is correctly passed along. Note: the runtime still has a branch to check if the `resolve_type` value is a tuple or not. The only case where this won't be true is for lazy resolved types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4085
Another option is to call
continue_valuein this code, which would change the behavior like this:This would be more like how objects are handle, but it would break some other tests in library. I'm open to it and I'll consider it if requested.