Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping static validation does not work. #4120

Closed
toneymathews opened this issue Jun 27, 2022 · 2 comments
Closed

Skipping static validation does not work. #4120

toneymathews opened this issue Jun 27, 2022 · 2 comments

Comments

@toneymathews
Copy link
Contributor

Describe the bug

#3881 was shipped to allow static validation to be skipped. ValidationPipeline called @query.validate to fetch the value. It was tagged with 1.13.9 but is not fully there in that version.

It is present in 2.0 +.

Can we pls get a 1.13.x version with the changes from #3881 ?

Versions

graphql version: 1.13.9 to 1.13.14

Steps to reproduce
This should be validate: @query.validate.

validation_result = @schema.static_validator.validate(@query, validate: @validate, timeout: @schema.validate_timeout, max_errors: @schema.validate_max_errors)

@toneymathews
Copy link
Contributor Author

Can we also add this PR to remove partial opentelemetry implementation in the new version?

@rmosolgo
Copy link
Owner

Derp, sorry about overlooking this the first time. I just released 1.13.15 with code from those to PRs. Please let me know if you encounter any trouble with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants