"Legacy .graphql_definition objects are deprecated and will be removed in GraphQL-Ruby 2.0" on a definition without graphql_definition

[alexeyr-ci]

I have this directive definition:

class GraphDirective::Cache < GraphQL::Schema::Directive
  argument :max_age, Integer, required: false, description: 'Cache expiration in seconds'
  locations QUERY
end

but when the app starts, I see

Legacy `.graphql_definition` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Remove `.graphql_definition` to use a class-based definition instead.

Called on GraphDirective::Cache from:
   /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:973:in `block in to_graphql'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:973:in `each'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:973:in `to_graphql'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema/member/accepts_definition.rb:129:in `to_graphql'  
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema/member/cached_graphql_definition.rb:52:in `to_graphql'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:921:in `graphql_definition'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:858:in `deprecated_graphql_definition'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/3.2.0/forwardable.rb:234:in `metadata'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-pro-1.25.2/lib/graphql/pro/operation_store.rb:52:in `use'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/graphql-1.13.23/lib/graphql/schema.rb:945:in `use'
  /home/alexey/shaka/popmenu/app/graphql/popmenu_schema.rb:33:in `<class:PopmenuSchema>'
  /home/alexey/shaka/popmenu/app/graphql/popmenu_schema.rb:4:in `<main>'
  <internal:/home/alexey/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
  <internal:/home/alexey/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:26:in `require'
  /home/alexey/shaka/popmenu/config/routes.rb:86:in `block (3 levels) in <main>'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/mapper.rb:871:in `scope'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/mapper.rb:1000:in `constraints'       
  /home/alexey/shaka/popmenu/config/routes.rb:82:in `block (2 levels) in <main>'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/mapper.rb:871:in `scope'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/mapper.rb:1000:in `constraints'       
  /home/alexey/shaka/popmenu/config/routes.rb:62:in `block in <main>'
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/route_set.rb:428:in `instance_exec'   
  /home/alexey/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.0.8.1/lib/action_dispatch/routing/route_set.rb:428:in `eval_block'

Looking at our code, graphql_definition is only called at the end of the schema class:

  # Force schema to fully resolve on app start
  # https://github.com/rmosolgo/graphql-ruby/issues/1505#issuecomment-412285264
  graphql_definition

Should it be replaced by

  use GraphQL::Execution::Interpreter 
  use GraphQL::Analysis::AST 

in the beginning of the class, as in the last comment on that issue #1505 (comment)? Or just not worry about it for now?

I'm just a bit confused why a directive triggers this warning but all the other definitions we already have don't.

[rmosolgo]

Hey, thanks for reporting this. I think this is triggered by some old code in OperationStore which isn't skipping a call to .metadata when it should.

I just released GraphQL-Pro 1.27.5 without this call (it was unused) -- does updating to that version work for you?