Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract box shadow CSS rule to a CSS variable #49

Open
rkclark opened this issue May 23, 2018 · 1 comment
Open

Extract box shadow CSS rule to a CSS variable #49

rkclark opened this issue May 23, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@rkclark
Copy link
Owner

rkclark commented May 23, 2018

box-shadow: 0 0.1rem 0.4rem 0 rgba(0, 0, 0, 0.4) is used 13 times across the project.

It should be included as a CSS variable in the src/css/units.css file and then imported into the files where it is needed.
mattpaulwilliamson added a commit to mattpaulwilliamson/pullp that referenced this issue Nov 28, 2018
@mattpaulwilliamson
Issue rkclark#49 - MW - Extract box shadow CSS rule to a CSS variable
3784b64
@mattpaulwilliamson
Copy link
Contributor

@rkclark I will take this issue if you don't mind. Thanks

@mattpaulwilliamson mattpaulwilliamson mentioned this issue Nov 28, 2018
Merged
rkclark pushed a commit that referenced this issue Nov 29, 2018
@mattpaulwilliamson @rkclark
Issue #49 - MW - Extract box shadow CSS rule to a CSS variable (#82)
879b591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattpaulwilliamson @rkclark