Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it compatible with native esm #4122

Open
1 task done
veeramarni opened this issue Mar 9, 2024 · 3 comments
Open
1 task done

make it compatible with native esm #4122

veeramarni opened this issue Mar 9, 2024 · 3 comments
Labels
awaiting response feature Is a feature request

Comments

@veeramarni
Copy link

Prerequisites

What theme are you using?

core

Is your feature request related to a problem? Please describe.

For vite SSR we get issues due to not natively supporting ESM.
Please check advise from https://publint.dev/@rjsf/chakra-ui@5.17.1advice

Describe the solution you'd like

Use type: module or rename esm files with extension .mjs

Describe alternatives you've considered

No response

@veeramarni veeramarni added feature Is a feature request needs triage Initial label given, to be assigned correct labels and assigned labels Mar 9, 2024
@heath-freenome
Copy link
Member

heath-freenome commented Mar 15, 2024

@veeramarni Are you sure you are importing the libraries correctly? We are using vite ourselves to run our playground and it works just fine. Our libraries export esm versions which I believe others are using. Can you provide the errors you are getting?

@heath-freenome heath-freenome added awaiting response and removed needs triage Initial label given, to be assigned correct labels and assigned labels Mar 15, 2024
@veeramarni
Copy link
Author

The issue happens when using SSR. Node 18 only support pure ESM as describe here

@heath-freenome
Copy link
Member

heath-freenome commented Mar 21, 2024

@veeramarni are you sure that you are importing the ESM versions of the RJSF repos? Again, we are using vite just fine with our repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response feature Is a feature request
Projects
None yet
Development

No branches or pull requests

2 participants