Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping bootstrap-4 support by renaming theme to react-bootstrap, using version 2 #3638

Closed
1 task done
heath-freenome opened this issue May 5, 2023 · 5 comments
Closed
1 task done
Assignees
Labels
feature Is a feature request

Comments

@heath-freenome
Copy link
Member

Prerequisites

What theme are you using?

bootstrap-4

Is your feature request related to a problem? Please describe.

Given that the bootstrap-4 theme is based on the react-bootstrap package and we are 1 major release behind we need to deal with both of those issues at the same time.

Describe the solution you'd like

We are planning to rename the theme in the next major release. At the same time, we will bump it to the react-bootstrap 2 version. This will be a breaking change

Describe alternatives you've considered

Provide a bootstrap-5 theme instead. We ruled this out because:

  1. It is 99% the same code
  2. Uses the same package name react-bootstrap
  3. Is inaccurately named
  4. Bootstrap "4" is no longer supported
@heath-freenome heath-freenome added the feature Is a feature request label May 5, 2023
@heath-freenome heath-freenome changed the title BREAKING CHANGE - Rename bootstrap-4 theme to react-bootstrap BREAKING CHANGE - Renaming bootstrap-4 theme to react-bootstrap May 5, 2023
@heath-freenome heath-freenome pinned this issue May 5, 2023
@heath-freenome heath-freenome changed the title BREAKING CHANGE - Renaming bootstrap-4 theme to react-bootstrap Dropping bootstrap-4 support by renaming theme to react-bootstrap, using version 2 May 5, 2023
@Dannergal
Copy link

I have a problem when I install boostrap 4 for react-schema-form:
image

import Form from '@rjsf/bootstrap-4';

@heath-freenome
Copy link
Member Author

@Dannergal Have you installed @rjsf/utils, @rjsf/core and @rjsf/validator-ajv8?

@Dannergal
Copy link

Dannergal commented Jun 13, 2023

Hi thanks for your support, in this thread:
#3729

Is necessary to Add in your documentation:

On the docs of react-bootstrap, they say you have to install bootstrap as well and import the css in your project. So I installed bootstrap npm install bootstrap and imported the styles like this:
@import 'bootstrap/scss/bootstrap';

@rmannibucau
Copy link

Hi,

any news? seems react-bootstrap now easily conflict with rjsf so can be good to integrate more recent versions

nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Nov 25, 2023
 - Add react-bootstrap package and use react-bootstrap v2, corresponding to Bootstrap 5
 - CheckboxesWidget: Remove deprecated prop `custom`
 - IconButton: Remove deprecated `block` prop
 - RangeWidget: Use `FormRange` component
 - SelectWidget: Use new FormSelect component, remove `bsPrefix` prop to achieve correct styling
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Dec 8, 2023
 - Add react-bootstrap package and use react-bootstrap v2, corresponding to Bootstrap 5
 - CheckboxesWidget: Remove deprecated prop `custom`
 - IconButton: Remove deprecated `block` prop
 - RangeWidget: Use `FormRange` component
 - SelectWidget: Use new FormSelect component, remove `bsPrefix` prop to achieve correct styling
@nickgros
Copy link
Contributor

Done in v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is a feature request
Projects
None yet
Development

No branches or pull requests

4 participants