Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that refs inside of allOf still work #3389

Closed
1 task done
nickgros opened this issue Jan 18, 2023 · 2 comments
Closed
1 task done

Verify that refs inside of allOf still work #3389

nickgros opened this issue Jan 18, 2023 · 2 comments
Assignees
Labels

Comments

@nickgros
Copy link
Contributor

nickgros commented Jan 18, 2023

Prerequisites

What theme are you using?

core

What is your question?

In #3227, we introduced a breaking change in retrieveSchema where refs are no longer immediately resolved inside of allOf. It's unclear if this these refs are eventually resolved, so we should add a test (similar to the one modified in #3227) where the schemas in allOf are references.

In addition to this test, we should document the breaking change, or fix/revert the change.

@nickgros nickgros added question needs triage Initial label given, to be assigned correct labels and assigned labels Jan 18, 2023
@nickgros nickgros self-assigned this Jan 18, 2023
@nickgros nickgros removed the needs triage Initial label given, to be assigned correct labels and assigned label Jan 18, 2023
@nickgros
Copy link
Contributor Author

Here's a schema that contains references inside of allOf. It seems to work just fine, so I don't believe that the change broke this behavior.

Playground link

@nickgros
Copy link
Contributor Author

This test also should confirm that this behavior didn't change:

it("should merge types with $ref in them", () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant