Simplify onAddClick code #3316
Labels
p1
Important to fix soon
Comments
github-actions
bot
added
the
needs triage
heath-freenome
added
p1
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this issue
Dec 28, 2022
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
8 tasks
heath-freenome
added a commit
that referenced
this issue
Dec 28, 2022
fixes: #3302, #3314, #3315, #3316 and #3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this issue
Jun 8, 2023
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this issue
Jun 8, 2023
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Replace onAddClick's implementation with just
onAddIndexClick(length + 1)as they should do the same thing. https://github.com/rjsf-team/react-jsonschema-form/blob/main/packages/core/src/components/fields/ArrayField.tsx#L228The text was updated successfully, but these errors were encountered: