fix: #3239 by providing an ErrorSchemaBuilder class in @rjsf/utils #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
approved these changes
Dec 22, 2022
| }); | ||
| }); | ||
| it("setting error string list without a path replaces at the root", () => { | ||
| expect(builder.setErrors(SOME_ERRORS).ErrorSchema).toEqual({ |
There was a problem hiding this comment.
I am personally not a fan of relying on the order of the tests to validate behavior, and would rather we start from scratch in beforeEach
There was a problem hiding this comment.
Given the differences in behavior of the addErrors() and setErrors() it seemed easier to build the tests this way. Did you want me to change it?
There was a problem hiding this comment.
It's fine, I agree this is easier and less code for something simple like this builder. Just a feeler to see how strongly you might agree 🙂
There was a problem hiding this comment.
In general I'm ok with doing incremental testing like this when it makes sense. Your feeler has revealed I weakly agree with you :)
…/utils fix: rjsf-team#3239 by providing a new `ErrorSchemaBuilder` class in `@rjsf/utils` - In `@rjsf/utils` added `ErrorSchemaBuilder` to facilitate building `ErrorSchema` objects without the need for fancy casting - Exported the new class as part of the main `index.js` - Added 100% unit tests - In `@rjsf/validator-ajv6` and `@rjsf/validator-ajv8` updated the `toErrorSchema()` function to use the `ErrorSchemaBuilder` to simplify the implementation - Also updated the tests to use the `ErrorSchemaBuilder` to replace the expected values that required doing `as ErrorSchema` casting - Updated the `utility-functions.md` file to document `ErrorSchemaBuilder` - Updated the `CHANGELOG.md` accordingly for this fix as well as PR rjsf-team#3297
heath-freenome
force-pushed
the
fix-3239
branch
from
8f0ed9a
to
cd34993
Compare
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…/utils (rjsf-team#3307) fix: rjsf-team#3239 by providing a new `ErrorSchemaBuilder` class in `@rjsf/utils` - In `@rjsf/utils` added `ErrorSchemaBuilder` to facilitate building `ErrorSchema` objects without the need for fancy casting - Exported the new class as part of the main `index.js` - Added 100% unit tests - In `@rjsf/validator-ajv6` and `@rjsf/validator-ajv8` updated the `toErrorSchema()` function to use the `ErrorSchemaBuilder` to simplify the implementation - Also updated the tests to use the `ErrorSchemaBuilder` to replace the expected values that required doing `as ErrorSchema` casting - Updated the `utility-functions.md` file to document `ErrorSchemaBuilder` - Updated the `CHANGELOG.md` accordingly for this fix as well as PR rjsf-team#3297
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…/utils (rjsf-team#3307) fix: rjsf-team#3239 by providing a new `ErrorSchemaBuilder` class in `@rjsf/utils` - In `@rjsf/utils` added `ErrorSchemaBuilder` to facilitate building `ErrorSchema` objects without the need for fancy casting - Exported the new class as part of the main `index.js` - Added 100% unit tests - In `@rjsf/validator-ajv6` and `@rjsf/validator-ajv8` updated the `toErrorSchema()` function to use the `ErrorSchemaBuilder` to simplify the implementation - Also updated the tests to use the `ErrorSchemaBuilder` to replace the expected values that required doing `as ErrorSchema` casting - Updated the `utility-functions.md` file to document `ErrorSchemaBuilder` - Updated the `CHANGELOG.md` accordingly for this fix as well as PR rjsf-team#3297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fix: #3239 by providing a new
ErrorSchemaBuilderclass in@rjsf/utils@rjsf/utilsaddedErrorSchemaBuilderto facilitate buildingErrorSchemaobjects without the need for fancy castingindex.js@rjsf/validator-ajv6and@rjsf/validator-ajv8updated thetoErrorSchema()function to use theErrorSchemaBuilderto simplify the implementationErrorSchemaBuilderto replace the expected values that required doingas ErrorSchemacastingutility-functions.mdfile to documentErrorSchemaBuilderCHANGELOG.mdaccordingly for this fix as well as PR fix(material-ui): fix RangeWidget onChange handler #2161 #3297Checklist
npm run test:updateto update snapshots, if needed.