Update babel.config.js so build artifacts are compiled to ES5. #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dts-cli will utilize the babel.config.js file on build. The `targets` option for the @babel/preset-env plugin will determine what features the compiled output will target. Per babel docs: > When no targets are specified: Babel will assume you are targeting the oldest browsers possible. For example, @babel/preset-env will transform all ES2015-ES2020 code to be ES5 compatible. This approach will allow us to continue to write ESNext code while we can be confident RJSF users will still consume ES5 code.
4 tasks
heath-freenome
approved these changes
Dec 21, 2022
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…team#3304) dts-cli will utilize the babel.config.js file on build. The `targets` option for the @babel/preset-env plugin will determine what features the compiled output will target. Per babel docs: > When no targets are specified: Babel will assume you are targeting the oldest browsers possible. For example, @babel/preset-env will transform all ES2015-ES2020 code to be ES5 compatible. This approach will allow us to continue to write ESNext code while we can be confident RJSF users will still consume ES5 code.
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…team#3304) dts-cli will utilize the babel.config.js file on build. The `targets` option for the @babel/preset-env plugin will determine what features the compiled output will target. Per babel docs: > When no targets are specified: Babel will assume you are targeting the oldest browsers possible. For example, @babel/preset-env will transform all ES2015-ES2020 code to be ES5 compatible. This approach will allow us to continue to write ESNext code while we can be confident RJSF users will still consume ES5 code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
dts-cli will utilize the babel.config.js file on build. The
targetsoption for the @babel/preset-env plugin will determine what features the compiled output will target. Per babel docs:This approach will allow us to continue to write ESNext code while we can be confident RJSF users will still consume ES5 code.
Fixes #3240
Checklist
npm run test:updateto update snapshots, if needed.