fix: 3253 By adding schema to ArrayFieldTemplateItemType type #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: rjsf-team#3253 by adding `schema` prop `ArrayFieldTemplateItemType` type to make it consistent with all the rest of the template types - In `@rjsf/utils`, updated `types.ts` to add `schema` to the `ArrayFieldTemplateItemType` type - In `@rjsf/core`, updated the `ArrayField` template to pass the `schema` to the props that are provided to the instance of the `ArrayFieldItemTemplate` - Updated `custom-templates.md` to add the `schema` to the documentation for `ArrayFieldItemTemplate` - Updated the `CHANGELOG.md` accordingly
jacqueswho
approved these changes
Dec 17, 2022
nickgros
approved these changes
Dec 18, 2022
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…eam#3298) fix: rjsf-team#3253 by adding `schema` prop `ArrayFieldTemplateItemType` type to make it consistent with all the rest of the template types - In `@rjsf/utils`, updated `types.ts` to add `schema` to the `ArrayFieldTemplateItemType` type - In `@rjsf/core`, updated the `ArrayField` template to pass the `schema` to the props that are provided to the instance of the `ArrayFieldItemTemplate` - Updated `custom-templates.md` to add the `schema` to the documentation for `ArrayFieldItemTemplate` - Updated the `CHANGELOG.md` accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…eam#3298) fix: rjsf-team#3253 by adding `schema` prop `ArrayFieldTemplateItemType` type to make it consistent with all the rest of the template types - In `@rjsf/utils`, updated `types.ts` to add `schema` to the `ArrayFieldTemplateItemType` type - In `@rjsf/core`, updated the `ArrayField` template to pass the `schema` to the props that are provided to the instance of the `ArrayFieldItemTemplate` - Updated `custom-templates.md` to add the `schema` to the documentation for `ArrayFieldItemTemplate` - Updated the `CHANGELOG.md` accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fix: #3253 by adding
schemapropArrayFieldTemplateItemTypetype to make it consistent with all the rest of the template types@rjsf/utils, updatedtypes.tsto addschemato theArrayFieldTemplateItemTypetype@rjsf/core, updated theArrayFieldtemplate to pass theschemato the props that are provided to the instance of theArrayFieldItemTemplatecustom-templates.mdto add theschemato the documentation forArrayFieldItemTemplateCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.