isObject should return false for Date as well as File, null, and Array #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, update the |
BenBeattieHood
force-pushed
the
patch-1
branch
from
78e4c10
to
2221b78
Compare
|
Thanks for your guidance @heath-freenome 👍 I've updated the tests and the changelog as required. |
heath-freenome
approved these changes
Dec 21, 2022
|
@BenBeattieHood Also, I'm guessing that you didn't have the git precommit install hook properly installed (see the docs on how to do that). Therefore, you will need to run |
Without this, assigning dates to the form's value instead merges them with a default value for objects of `{}` (in mergeDefaultsWithFormData), which stops them being dates.
BenBeattieHood
force-pushed
the
patch-1
branch
from
f2eef6b
to
428903a
Compare
|
Aah! I see that now. Thanks for the guidance & docs on this. Ok, have applied the lint formatting and rebased for a clean diff. |
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
rjsf-team#3292) * Tests for existing 'isObject' functionality * isObject should return false for Date as well as File, null, and Array Without this, assigning dates to the form's value instead merges them with a default value for objects of `{}` (in mergeDefaultsWithFormData), which stops them being dates. * Corrected changelog entry * Update CHANGELOG.md * Lint formatting tests Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
rjsf-team#3292) * Tests for existing 'isObject' functionality * isObject should return false for Date as well as File, null, and Array Without this, assigning dates to the form's value instead merges them with a default value for objects of `{}` (in mergeDefaultsWithFormData), which stops them being dates. * Corrected changelog entry * Update CHANGELOG.md * Lint formatting tests Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Without this, assigning dates to the form's value instead merges them with a default value for objects of
{}(in mergeDefaultsWithFormData), which stops them being dates.Checklist
npm run test:updateto update snapshots, if needed.