fix(@rjsf/core): Nested into items schema allOf blocks with multiple … #3025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…if/then/else statements fail to render correctly
When schema (or subschema) has
allOf
in the root AND has an array field with a property where existsallOf
with few conditions RJSF doesn't handle this case properly. The console shows the warningcould not merge subschemas in allOf
and dependent properties don't reflect the schema. This is an example - if you remove rootallOf
the playground example will work.After diving into the RJSF source code and looking around at dependent libraries, I found the solution, which makes these schemas work.
json-schema-merge-allof@0.8.1
- this version allows to resolve only the top-levelallOf
keyword in the schema;utils.retreiveSchema
method - pass{ deep: false }
into the merger;I'm not sure about any regression this change may introduce, but it works for the first look. All tests (except the fixed one that checked a nested merging
allOf
blocks) pass. All my schemas (including schemas that required #2839) worksChecklist
npm run test:update
to update snapshots, if needed.