Setting Form prop extraErrors changes the structure of propagated error objects

[iwan-uschka]

Prerequisites

• I have read the documentation;
• In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
• Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

If extraErrors is set as a <Form /> prop (it just needs to be an empty object) the errors array (in the transformErrors or onError callback) doesn't provide the same error object data structure.

With extraErrors being set:

[
  {stack: 'salutation: Is required.'},
  ...
]

Without extraErrors being set:

[
  {
    message: "is a required property",
    name: "required",
    params: {missing Property: 'salutation'},
    property: ".address.salutation",
    schemaPath: "#/properties/address/required",
    stack: ".address.salutation is a required property
  },
  ...
]

Is this behavior intentional? I couldn't find any hint in the docs.

Expected behavior

I would like to have internal errors being defined as detailed as possible no matter if some external extraErrors are brought into the error stack.

Actual behavior

Internal errors are becoming less detailed if external extraErrors are set.

See https://codesandbox.io/s/interesting-hertz-vo5ef?file=/src/App.js using 3.1.0.

If i use the JSFiddle template from above (which is using 1.8.1 as it seems, see https://unpkg.com/react-jsonschema-form/dist/react-jsonschema-form.js) the "error" doesn't occur. See https://jsfiddle.net/01qwf23d/4/.

Version

3.1.0

[hughjdavey]

This also seems to happen if you use the customValidation option - even if your custom validation function just returns errors unchanged like

function validate(formData, errors) {
    return errors;
}

If I don't use customValidation, I get error stacks like .contact_info.address.line1 is a required property but when it is set, the stacks all become e.g. line1: is a required property.

This is on ^4.1.1 btw.

[hughjdavey]

I have made a JSFiddle for this - https://jsfiddle.net/mdeazLy3/1/

There are 2 forms, one with a validate function and one without. The one with the function returns truncated error.stacks:

[hughjdavey]

Since this is old I opened #3262 - let me know if that wasn't the right thing to do

[heath-freenome]

Since this is old I opened #3262 - let me know if that wasn't the right thing to do

@hughjdavey I'm treating #3262 as a documentation bug and will fix that one accordingly. I believe that the specific bug in this issue is already fixed in the v5 beta... Closing this accordingly

[iwan-uschka]

A little late but we're finally in the process of migrating to rjsf@5 and i can confirm that this error has been fixed. Thx!