Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): do not acquire quota for shared buffer in serving mode #16753

Merged

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented May 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #16716

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@kwannoel kwannoel added the need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged label May 17, 2024
@kwannoel
Copy link
Contributor

Let's include it in 1.9.1

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace Little-Wallace added this pull request to the merge queue May 21, 2024
Merged via the queue into risingwavelabs:main with commit 43f78cd May 21, 2024
27 of 28 checks passed
@Little-Wallace Little-Wallace deleted the wallace/fix-serving-memory branch May 21, 2024 08:19
Little-Wallace added a commit that referenced this pull request May 22, 2024
…16753)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Increasing Shared Buffer Size, encounters Block Cache Capacity must be positive and serving node crashes
3 participants