Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating profile image does not change profile image at older files #317

Open
jnachtigall opened this issue Sep 1, 2015 · 4 comments
Open

Comments

@jnachtigall
Copy link

I've changed my image under Settings > Icon to another image (anyway, why is the profile image called "Icon"? (german)).

Afterwards all new pages and files I upload have the new image attached to them (good!). However, at the old files (that I upload before changing the image) there is still my old profile image (bad!)

This causes confusion as one might think that these are two different persons. (Actually, I just changed my profile image to a photo of mine because someone with the same first name joined our group... Now it's really a bit confusing, 2 people with similar name and 3 photos/icons ;-)

Maybe an reindexing of the user's files or similar should be done when changing the image.

@azul
Copy link
Contributor

azul commented Sep 2, 2015

thanks for the report. I changed my profile image recently too, so i will use that to quickly take a look at files i uploaded before. I'm not quite sure which part of the ui you mean. I hope to find it but a screenshot might proof useful eventually.

@jnachtigall
Copy link
Author

Now, it's been updated (one or two days later). Don't know why there's been a time lag in the photo update...

It was in the pages listing ("Aktuelle Seiten", i.e. <h2 class="pages">) of a group. There it was in the "Aktualisiert" (Updated) row, i.e. <th class="updated" colspan="2">. Hope this description is sufficient, otherwise I can also sent a screenshot, but would need to edit the image as the group is private (let me know if you still need it, and maybe your email address for a PM) - but as said, now it is all fine.

I am still not closing the bug as you might want to investigate why there's a time lag of about 2 days for updating the profile image for older pages/files. Go ahead and close if you feel it is ok.

@azul
Copy link
Contributor

azul commented Sep 4, 2015

this sure is an issue.
We are caching the page rows and the cache key should change when the avatar of a user changes. Now it may have changed for a different reason. For example the timestamp may have changed from "yesterday" to "wednesday" or so.
We need to make sure the updated_at timestamp of the page changes.

@elijh
Copy link
Contributor

elijh commented Feb 1, 2016

this is also true for groups, the avatar is too aggressively cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants